reduce copying of large messages while sending #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 82.02% 82.71% +0.69%
==========================================
Files 9 9
Lines 1029 1030 +1
==========================================
+ Hits 844 852 +8
+ Misses 185 178 -7
Continue to review full report at Codecov.
|
This change avoids copying entire large messages into memory while sending. Instead of earlier approach of chunking the entire message before starting to send, we now chunk as we proceed with sending message over the channel. The memory overhead is limited to the sendq size.
now that CI is moved to github workflows, we don't need them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids copying entire large messages into memory while sending. Instead of earlier approach of chunking the entire message before starting to send, we now chunk as we proceed with sending message over the channel. The memory overhead is limited to the sendq size.